feat: activity tab on schema explorer [ENG-1647] by speaker-ender · Pull Request #7162 · ethyca/fides

speaker-ender · 2025-12-18T22:00:59Z

Ticket ENG-1647

Description Of Changes

Adds the Activity tab to monitor screens so that users can view activity specific to a monitor they are working on.

Code Changes

Refactoring the page structure and tab navigation for the Action-Center to contain a shared layout.
Creating a pattern for page navigation via tabs
Removing some complexity from filtering

Steps to Confirm

Visit the Helios V2 action center
Navigate to a datastore monitor tree view
Confirm that the Activity tab is visible
Confirm that navigating to the Activity tab only displays values specific to the monitor being viewed by changing the filter to include all activity types.
Verify that no regressions on the existing Activity tab

Pre-Merge Checklist

vercel · 2025-12-18T22:01:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Jan 13, 2026 2:18pm

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
fides-privacy-center	Ignored		Jan 13, 2026 2:18pm

greptile-apps · 2026-01-06T15:08:52Z

Greptile Summary

Refactored action center to support tab-based navigation and added monitor-scoped activity views.

Key changes:

Created shared ActionCenterLayout component with tab navigation for both root and monitor-specific views
Added new "Activity" tab at root level (/action-center/activity) and monitor level (/action-center/datastore/[monitorId]/activity)
Extracted MonitorList component from page with search and pagination
Refactored ActionCenterFields from Next.js page to component accepting monitorId prop
Simplified filter logic in useFilters by removing useEffect and using default values directly in query state
Created reusable useMenuNavigation hook for generic menu-based navigation with route configuration
Built InProgressMonitorTasksList component that accepts optional monitorId filter for scoped activity views

Issues:

MonitorList uses local state for search instead of the existing useSearch hook, breaking URL state synchronization pattern used elsewhere

Confidence Score: 4/5

Safe to merge with minor style improvements recommended
Well-structured refactoring with good separation of concerns and reusable patterns. The PR exceeds size guidelines (19 files, 755 total line changes vs 15 files/500 lines limit per rule 32b2f192-9cdf-48f0-be68-5c0eaa04fc70), but changes are cohesive. Minor inconsistency with search state management pattern in MonitorList component.
Pay attention to MonitorList.tsx - should use useSearch hook for consistency

Important Files Changed

Filename	Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/ActionCenterLayout.tsx	New shared layout component for action center with tab navigation - clean implementation
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useActionCenterNavigation.tsx	Custom hook for action center tab navigation with feature flag support
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InProgressMonitorTasksList.tsx	Activity list component with filtering and pagination - accepts optional monitorId filter
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx	Refactored to component accepting monitorId prop instead of Next.js page with router access
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx	Extracted monitor list component from page with search and pagination - has minor issue with search state management

greptile-apps

_{19 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-06T15:08:50Z

clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx

+
+  return (
+    <Flex className="h-[calc(100%-48px)] overflow-hidden" gap="middle" vertical>
+      <Flex className="justify-between ">


style: update onChange to use updateSearch from useSearch hook

If switching to useSearch hook, update this to use updateSearch instead of setSearchQuery

Suggested change

<Flex className="justify-between ">

<DebouncedSearchInput value={searchQuery} onChange={updateSearch} />

Context Used: Rule from dashboard - Use the existing useSearch hook for search functionality to maintain URL state synchronization ins... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

another miss

greptile-apps · 2026-01-06T15:08:51Z

...eatures/data-discovery-and-detection/action-center/components/InProgressMonitorTasksList.tsx

+            hidden={!!filters?.monitorId}
+            value={filters?.monitorId ?? searchQuery ?? ""}


style: search input hidden but still shows monitorId as value when filtered

When filters?.monitorId is provided, the search input is hidden but still displays the monitorId as its value. Consider passing undefined or empty string when hidden for consistency

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

This is intentional for the moment

I'm also not sure why we need to show a hidden input with a value?

@lucanovera It's a temporary hack for how the screen works to filter by monitor.
We don't want to show the input because it shouldn't be changed by the user.
Disabling it would look broken + it's not showing any useful information.

greptile-apps · 2026-01-06T15:08:51Z

clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx

+    flags: { webMonitor: webMonitorEnabled, heliosV2: heliosV2Enabled },
+  } = useFeatures();
+  const { paginationProps, pageIndex, pageSize, resetPagination } =
+    useAntPagination();


style: use useSearch hook instead of local state for search

This component uses local useState for search, but the existing useSearch hook should be used to maintain URL state synchronization (as done in other components like InProgressMonitorTasksList)

Suggested change

useAntPagination();

const { searchQuery, updateSearch } = useSearch();

Context Used: Rule from dashboard - Use the existing useSearch hook for search functionality to maintain URL state synchronization ins... (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Wrong line. Also was existing code. Trying to reduce the amount of changes in a single pr

lucanovera

The new menu / page routing code looks good. I see the Activity tab but it's got no results on it. Can you include instructions for how to see results in there or a link to the preview where it has results?

lucanovera · 2026-01-09T13:53:11Z

clients/admin-ui/src/features/common/hooks/useMenuNavigation.ts

+  defaultKey?: Exclude<keyof R, symbol | number>;
+}
+
+const useMenuNavigation = <


Thanks for implementing this as a generic we can reuse. That will be useful when refactoring old tabs with hashes for pages and menus.

lucanovera · 2026-01-09T14:00:08Z

...eatures/data-discovery-and-detection/action-center/components/InProgressMonitorTasksList.tsx

+            hidden={!!filters?.monitorId}
+            value={filters?.monitorId ?? searchQuery ?? ""}


I'm also not sure why we need to show a hidden input with a value?

speaker-ender · 2026-01-12T15:31:09Z

@lucanovera

The new menu / page routing code looks good. I see the Activity tab but it's got no results on it. Can you include instructions for how to see results in there or a link to the preview where it has results?

I've updated the instructions. You just need to adjust your filters to show all the different types of events. It defaults to hide common activity.

fix: title for tests wip: more refactoring refactor: page structure fix: minor style issues refactor: page based wip: still standardizing wip: further refactors refactor: filter related changes linting and other fixes fix: type issue fix: broken imports chore: update changelog fix: more imports

lucanovera

UI looks good and behaves correctly, tested different filters, search, etc. Approved!

vercel bot had a problem deploying to Preview – fides-plus-nightly December 18, 2025 22:02 Failure

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from 40f657d to 471cb51 Compare December 18, 2025 22:02

vercel bot had a problem deploying to Preview – fides-plus-nightly December 18, 2025 22:05 Failure

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from 471cb51 to 047cce0 Compare December 18, 2025 22:13

vercel bot deployed to Preview – fides-plus-nightly December 18, 2025 22:18 View deployment

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from 047cce0 to 9d243cb Compare December 19, 2025 18:10

vercel bot deployed to Preview – fides-plus-nightly December 19, 2025 18:15 View deployment

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from 9d243cb to dc31bbc Compare January 6, 2026 14:36

vercel bot had a problem deploying to Preview – fides-plus-nightly January 6, 2026 14:39 Failure

vercel bot had a problem deploying to Preview – fides-plus-nightly January 6, 2026 14:48 Failure

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from 2899a1b to 1764fd9 Compare January 6, 2026 14:50

vercel bot had a problem deploying to Preview – fides-plus-nightly January 6, 2026 14:53 Failure

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from 1ef20e5 to f507531 Compare January 6, 2026 14:55

vercel bot deployed to Preview – fides-plus-nightly January 6, 2026 15:01 View deployment

speaker-ender marked this pull request as ready for review January 6, 2026 15:04

speaker-ender requested a review from a team as a code owner January 6, 2026 15:04

speaker-ender requested review from lucanovera and removed request for a team January 6, 2026 15:04

greptile-apps bot reviewed Jan 6, 2026

View reviewed changes

lucanovera reviewed Jan 9, 2026

View reviewed changes

speaker-ender force-pushed the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch from f507531 to f67271d Compare January 13, 2026 14:13

speaker-ender requested a review from lucanovera January 13, 2026 14:14

vercel bot deployed to Preview – fides-plus-nightly January 13, 2026 14:18 View deployment

lucanovera approved these changes Jan 13, 2026

View reviewed changes

speaker-ender added this pull request to the merge queue Jan 13, 2026

Merged via the queue into main with commit 4a160de Jan 13, 2026
44 of 46 checks passed

speaker-ender deleted the feat/activity-tab-on-schema-explorer--ENG-1647--refactor branch January 13, 2026 15:00

speaker-ender mentioned this pull request Jan 14, 2026

fix: okta integration filtering #7226

Merged

18 tasks

mfbrown pushed a commit that referenced this pull request Jan 27, 2026

feat: activity tab on schema explorer [ENG-1647] (#7162)

de1e18a

	<Flex className="justify-between ">
	<DebouncedSearchInput value={searchQuery} onChange={updateSearch} />

		hidden={!!filters?.monitorId}
		value={filters?.monitorId ?? searchQuery ?? ""}

	useAntPagination();
	const { searchQuery, updateSearch } = useSearch();

Conversation

speaker-ender commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 6, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

lucanovera Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

lucanovera left a comment

Choose a reason for hiding this comment

Uh oh!

lucanovera Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

lucanovera Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender commented Jan 12, 2026

Uh oh!

lucanovera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

speaker-ender commented Dec 18, 2025 •

edited

Loading

vercel bot commented Dec 18, 2025 •

edited

Loading

speaker-ender Jan 12, 2026 •

edited

Loading