test: remove default test watch from privacy center#6671
Merged
gilluminate merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
5918b17 to
e6cb863
Compare
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Aligned privacy center test scripts with other workspace conventions.
- Changed
testscript inclients/privacy-center/package.jsonfromjest --watchAlltojest(run once) - Added new
test:watchscript withjest --watchAllfor continuous testing - Added
test:watchto rootclients/package.jsonto enableturbo run test:watchacross all workspaces - Matches the pattern already established in
admin-uiandfides-jsworkspaces
Confidence Score: 5/5
- This PR is completely safe to merge with zero risk
- This is a trivial quality-of-life change affecting only npm scripts. The changes align
privacy-centerwith conventions already established in other workspaces (admin-uiandfides-js). No production code, dependencies, or configurations are modified - only developer-facing test runner commands. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/privacy-center/package.json | 5/5 | Split test script into test (run once) and test:watch (with watcher), aligning with other workspaces |
| clients/package.json | 5/5 | Added test:watch script to enable watching tests across all workspaces via turbo |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Root as clients/package.json
participant Turbo as Turbo
participant PC as privacy-center/package.json
participant Jest as Jest
Note over Dev,Jest: Test (run once)
Dev->>Root: npm run test
Root->>Turbo: turbo run test
Turbo->>PC: Execute test script
PC->>Jest: jest
Jest-->>Dev: Exit with pass/fail
Note over Dev,Jest: Test Watch (continuous)
Dev->>Root: npm run test:watch
Root->>Turbo: turbo run test:watch
Turbo->>PC: Execute test:watch script
PC->>Jest: jest --watchAll
Jest-->>Dev: Watch mode active
2 files reviewed, no comments
8e5cf12 to
1eafa1a
Compare
gilluminate
approved these changes
Oct 24, 2025
chore: adding global script
6a9dad2 to
0c267b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Quality of life change.
Aligns the privacy center test scripts so that the default
testjob only runs once.A separate
test:watchjob is added for running tests with the watcher.Code Changes
Steps to Confirm
turbo run testand confirm that the script exits with pass/fail valuesturbo run test:watchand confirm that all test suites re-run on changesPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works