Skip to content

test: remove default test watch from privacy center#6671

Merged
gilluminate merged 2 commits intomainfrom
test/remove-default-test-watch-from-privacy-center
Feb 23, 2026
Merged

test: remove default test watch from privacy center#6671
gilluminate merged 2 commits intomainfrom
test/remove-default-test-watch-from-privacy-center

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented Sep 29, 2025

Description Of Changes

Quality of life change.
Aligns the privacy center test scripts so that the default test job only runs once.
A separate test:watch job is added for running tests with the watcher.

Code Changes

  • No changes to actual code. Only package scripts updated.

Steps to Confirm

  1. Run turbo run test and confirm that the script exits with pass/fail values
  2. Run turbo run test:watch and confirm that all test suites re-run on changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 23, 2026 7:07pm
fides-privacy-center Ignored Ignored Feb 23, 2026 7:07pm

Request Review

@speaker-ender speaker-ender force-pushed the test/remove-default-test-watch-from-privacy-center branch 2 times, most recently from 5918b17 to e6cb863 Compare October 13, 2025 14:17
@speaker-ender speaker-ender marked this pull request as ready for review October 13, 2025 14:20
@speaker-ender speaker-ender requested a review from a team as a code owner October 13, 2025 14:20
@speaker-ender speaker-ender requested review from eastandwestwind and removed request for a team October 13, 2025 14:20
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

Aligned privacy center test scripts with other workspace conventions.

  • Changed test script in clients/privacy-center/package.json from jest --watchAll to jest (run once)
  • Added new test:watch script with jest --watchAll for continuous testing
  • Added test:watch to root clients/package.json to enable turbo run test:watch across all workspaces
  • Matches the pattern already established in admin-ui and fides-js workspaces

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • This is a trivial quality-of-life change affecting only npm scripts. The changes align privacy-center with conventions already established in other workspaces (admin-ui and fides-js). No production code, dependencies, or configurations are modified - only developer-facing test runner commands.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/privacy-center/package.json 5/5 Split test script into test (run once) and test:watch (with watcher), aligning with other workspaces
clients/package.json 5/5 Added test:watch script to enable watching tests across all workspaces via turbo

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Root as clients/package.json
    participant Turbo as Turbo
    participant PC as privacy-center/package.json
    participant Jest as Jest

    Note over Dev,Jest: Test (run once)
    Dev->>Root: npm run test
    Root->>Turbo: turbo run test
    Turbo->>PC: Execute test script
    PC->>Jest: jest
    Jest-->>Dev: Exit with pass/fail

    Note over Dev,Jest: Test Watch (continuous)
    Dev->>Root: npm run test:watch
    Root->>Turbo: turbo run test:watch
    Turbo->>PC: Execute test:watch script
    PC->>Jest: jest --watchAll
    Jest-->>Dev: Watch mode active
Loading

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender force-pushed the test/remove-default-test-watch-from-privacy-center branch 2 times, most recently from 8e5cf12 to 1eafa1a Compare October 16, 2025 13:59
@gilluminate gilluminate removed the request for review from eastandwestwind February 23, 2026 19:06
@gilluminate gilluminate force-pushed the test/remove-default-test-watch-from-privacy-center branch from 6a9dad2 to 0c267b2 Compare February 23, 2026 19:07
@gilluminate gilluminate added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit fe4921c Feb 23, 2026
41 of 42 checks passed
@gilluminate gilluminate deleted the test/remove-default-test-watch-from-privacy-center branch February 23, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants