[fidesplus#807] adds fides_user_device_id to ProvidedIdentityType Enum#3131
Merged
seanpreston merged 1 commit intomainfrom Apr 24, 2023
Merged
[fidesplus#807] adds fides_user_device_id to ProvidedIdentityType Enum#3131seanpreston merged 1 commit intomainfrom
fides_user_device_id to ProvidedIdentityType Enum#3131seanpreston merged 1 commit intomainfrom
Conversation
fides_user_device_id to ProvidedIdentityType Enum
fides_user_device_id to ProvidedIdentityType Enumfides_user_device_id to ProvidedIdentityType Enum
Passing run #1502 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 308 308
Lines 17742 17743 +1
Branches 2288 2288
=======================================
+ Hits 15535 15536 +1
Misses 1792 1792
Partials 415 415
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pattisdr
reviewed
Apr 21, 2023
pattisdr
reviewed
Apr 21, 2023
src/fides/api/ctl/migrations/versions/3842d1acac5f_adds_fides_device_id_enum.py
Show resolved
Hide resolved
pattisdr
approved these changes
Apr 22, 2023
20 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/807
Code Changes
fides_user_device_idtoProvidedIdentityTypeenum and migrationSteps to Confirm
nox -s dev -- shellpip install ipythonipythonthen enter the following:Pre-Merge Checklist
CHANGELOG.md