Skip to content

[fidesplus#807] adds fides_user_device_id to ProvidedIdentityType Enum#3131

Merged
seanpreston merged 1 commit intomainfrom
sp/807/fides-device-id
Apr 24, 2023
Merged

[fidesplus#807] adds fides_user_device_id to ProvidedIdentityType Enum#3131
seanpreston merged 1 commit intomainfrom
sp/807/fides-device-id

Conversation

@seanpreston
Copy link
Copy Markdown
Contributor

@seanpreston seanpreston commented Apr 21, 2023

Closes https://github.com/ethyca/fidesplus/issues/807

Code Changes

  • Adds fides_user_device_id to ProvidedIdentityType enum and migration

Steps to Confirm

  • nox -s dev -- shell
  • pip install ipython
  • ipython then enter the following:
from fides.api.ops.models.privacy_request import ProvidedIdentityType, ProvidedIdentity
from fides.core.config import get_config
from fides.lib.db.session import get_db_session
db = get_db_session(get_config())()
pi = ProvidedIdentity.create(db=db, data={"field_name": "fides_user_device_id"})
assert pi.field_name.value == "fides_user_device_id"

Pre-Merge Checklist

@seanpreston seanpreston requested a review from pattisdr April 21, 2023 21:25
@seanpreston seanpreston changed the title [#807] adds fides_user_device_id to ProvidedIdentityType Enum [#807] adds fides_user_device_id to ProvidedIdentityType Enum Apr 21, 2023
@seanpreston seanpreston changed the title [#807] adds fides_user_device_id to ProvidedIdentityType Enum [fidesplus#807] adds fides_user_device_id to ProvidedIdentityType Enum Apr 21, 2023
@cypress
Copy link
Copy Markdown

cypress bot commented Apr 21, 2023

Passing run #1502 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 491714c into d39da31...
Project: fides Commit: eae1b831ea ℹ️
Status: Passed Duration: 00:44 💡
Started: Apr 21, 2023 9:34 PM Ended: Apr 21, 2023 9:35 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d39da31) 87.56% compared to head (491714c) 87.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3131   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         308      308           
  Lines       17742    17743    +1     
  Branches     2288     2288           
=======================================
+ Hits        15535    15536    +1     
  Misses       1792     1792           
  Partials      415      415           
Impacted Files Coverage Δ
src/fides/api/ops/models/privacy_request.py 96.20% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants