You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use espup instead of rust-build script for installation. This should also solve #15 as it removes the call, and relies on the version check to espup.
Time-wise, the action takes around 2 minutes, the same as the rust-build scripts used to last.
Also, I've created another branch that improves the cases covered by the CI as many arguments are not covered atm, if we endup merging this PR, I'll create another one for it.
This is looking pretty good, as far as I can tell. Thanks for making these updates, hopefully it will be a bit more reliable.
~2 minutes is acceptable I think, I would still like to get it down a bit but it's reasonable. Something we can work on in the future.
Out of curiosity have you tested the workflow with any of the repositories currently using it (eg. esp-hal) or are we just relying on the local CI? In theory our CI should be fine, but I'd just like to be certain that things work as expected. You can use owner/repo@hash to run an unpublished action (see the docs).
~2 minutes is acceptable I think, I would still like to get it down a bit but it's reasonable. Something we can work on in the future.
Once espup is async, this should be improved!
Out of curiosity have you tested the workflow with any of the repositories currently using it (eg. esp-hal) or are we just relying on the local CI? In theory our CI should be fine, but I'd just like to be certain that things work as expected. You can use owner/repo@hash to run an unpublished action (see the docs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
espupinstead ofrust-buildscript for installation. This should also solve #15 as it removes the call, and relies on the version check toespup.Time-wise, the action takes around 2 minutes, the same as the
rust-buildscripts used to last.Also, I've created another branch that improves the cases covered by the CI as many arguments are not covered atm, if we endup merging this PR, I'll create another one for it.