let runTrafficTest polling retry on mismatch#8830
Draft
jukie wants to merge 2 commits intoenvoyproxy:mainfrom
Draft
let runTrafficTest polling retry on mismatch#8830jukie wants to merge 2 commits intoenvoyproxy:mainfrom
jukie wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
66dc61e to
3d26bcd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8830 +/- ##
==========================================
- Coverage 73.64% 73.61% -0.03%
==========================================
Files 246 246
Lines 49076 49109 +33
==========================================
+ Hits 36140 36154 +14
- Misses 10916 10930 +14
- Partials 2020 2025 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
runTrafficTest was calling t.FailNow() whenever compareFunc returned false, which aborted the subtest before wait.PollUntilContextTimeout could retry. The BackendUtilizationLoadBalancing warmup subtest expects retries while Envoy's EDS cluster converges to healthy endpoints, so a single empty trafficMap on the first iteration would fail the test outright. Return false instead and move the diagnostic cluster dump into each caller's poll-timeout branch so it runs once on real failure rather than on every retry.
Fixes #8826