Skip to content

Lower parse error log level to debug #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Mar 31, 2026
Merged

Lower parse error log level to debug #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/sshproxy/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,11 @@ func handleConnectionError(ctx context.Context, err error) {
"unmarshal error",
// https://github.com/golang/crypto/blob/982eaa62dfb7273603b97fc1835561450096f3bd/ssh/common.go#L382
"unexpected message type",
// https://github.com/golang/crypto/blob/982eaa62dfb7273603b97fc1835561450096f3bd/ssh/common.go#L387
// All errors collected in the wild are about `SSH_MSG_USERAUTH_REQUEST` (50), see `serverAuthenticate()`:
// https://github.com/golang/crypto/blob/982eaa62dfb7273603b97fc1835561450096f3bd/ssh/server.go#L530
// but we suppress all such errors as any malformed message is suspicious, esp. during authentication
"parse error in message type",
} {
if strings.Contains(errMsg, msg) {
logger.WithError(err).Debug("suspicious client")
Expand Down