Skip to content

Add /regfile and /codebaseroot options#402

Open
QVIDevOps wants to merge 2 commits intodspace-group:mainfrom
QVIDevOps:add-regfile-option
Open

Add /regfile and /codebaseroot options#402
QVIDevOps wants to merge 2 commits intodspace-group:mainfrom
QVIDevOps:add-regfile-option

Conversation

@QVIDevOps
Copy link

  • /regfile: adds ability to create .reg file for later import.
  • /codebaseroot: allows reg files to be used on a target host.

@marklechtermann
Copy link
Member

marklechtermann commented Mar 6, 2026

THX for your pull request ❤️! Can you fix the linter errors?

Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(220,13): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(394,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(521,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(542,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(569,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(939,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(965,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegisterAssemblySettings.cs(51,1): warning IDE0055: Fix formatting [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(220,13): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(394,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(521,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(542,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(569,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(939,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(965,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(117,48): warning CA1805: Member '_regFileWriter' is explicitly initialized to its default value [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(220,13): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(394,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(521,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(542,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(569,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(939,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(965,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(117,50): warning CS8625: Cannot convert null literal to non-nullable reference type. [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegisterAssemblySettings.cs(51,1): warning IDE0055: Fix formatting [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(117,48): warning CA1805: Member '_regFileWriter' is explicitly initialized to its default value [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(220,13): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(394,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(939,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(965,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(521,17): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(542,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(569,21): warning IDE0045: 'if' statement can be simplified [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Warning: D:\a\dscom\dscom\src\dscom\RegistrationServices.cs(117,50): warning CS8625: Cannot convert null literal to non-nullable reference type. [D:\a\dscom\dscom\src\dscom\dscom.csproj]
Error: Process completed with exit code 1.

- `/regfile`: adds ability to create `.reg` file for later import.
- `/codebaseroot`: allows reg files to be used on a target host.
- Simplified if statements
- Use nullable type and allow implicit initialization
@QVIDevOps QVIDevOps force-pushed the add-regfile-option branch from 958a2ce to 14166d0 Compare March 6, 2026 20:22
@QVIDevOps
Copy link
Author

Updated and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants