Issue #2947227: Coupon access should not break if coupon is not attac… #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hed to a promotion
mglaman
reviewed
Feb 28, 2018
| $result = parent::checkAccess($entity, $operation, $account); | ||
|
|
||
| if ($result->isNeutral()) { | ||
| if ($result->isNeutral() && $promotion = $entity->getPromotion()) { |
Contributor
There was a problem hiding this comment.
If there is no promotion it should always be false, because nothing can be applied.
Contributor
There was a problem hiding this comment.
We should explicitly deny.
This is part of the bigger data integrity issues we have.
Contributor
|
Let's finish this on the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem/Motivation
Fatal error occur when trying to check access on a coupon which is not attached to a promotion.
Proposed resolution
Check coupon has promotion before using the access method of this promotion.
See https://www.drupal.org/project/commerce/issues/2947227