Skip to content

Fix IChatClient integration tests after relaxed JSON update #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Feb 7, 2025
Merged

Fix IChatClient integration tests after relaxed JSON update #5859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Libraries/Microsoft.Extensions.AI.Integration.Tests/ChatClientIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ public virtual async Task Logging_LogsCalls_NonStreaming()
await chatClient.CompleteAsync([new(ChatRole.User, "What's the biggest animal?")]);

Assert.Collection(collector.GetSnapshot(),
entry => Assert.Contains("What\\u0027s the biggest animal?", entry.Message),
entry => Assert.Contains("What's the biggest animal?", entry.Message),
entry => Assert.Contains("whale", entry.Message));
}

Expand All @@ -542,7 +542,7 @@ public virtual async Task Logging_LogsCalls_Streaming()
}

var logs = collector.GetSnapshot();
Assert.Contains(logs, e => e.Message.Contains("What\\u0027s the biggest animal?"));
Assert.Contains(logs, e => e.Message.Contains("What's the biggest animal?"));
Assert.Contains(logs, e => e.Message.Contains("whale"));
}

Expand Down