Skip to content

Fix uri comparing - #974

Merged
nbulaj merged 1 commit into
doorkeeper-gem:masterfrom
earlymarket:fix-uri-comparing
Jan 26, 2018
Merged

Fix uri comparing#974
nbulaj merged 1 commit into
doorkeeper-gem:masterfrom
earlymarket:fix-uri-comparing

Conversation

@dmitrytrager

Copy link
Copy Markdown

when doing checks from authorization code request

Related to: #949

@nbulaj

nbulaj commented Jun 16, 2017

Copy link
Copy Markdown
Member

@maclover7 I think it is ready to be merged.

@maclover7

Copy link
Copy Markdown
Contributor

Hi @dmitrytrager! Can you squash your commits? Other than that, looks ready to go 👍

@dmitrytrager

Copy link
Copy Markdown
Author

@maclover7 Tried to squach commit. Please, check.

@maclover7

Copy link
Copy Markdown
Contributor

@dmitrytrager Looks like the squash worked, but your commit message got cleared somehow. Maybe try using git commit --amend to edit it? 😬

@dmitrytrager

Copy link
Copy Markdown
Author

Hey @maclover7

This is commit I'm able to see:
commit

If you think this is not appropriate message, please, add whatever you want to this message)

@maclover7

Copy link
Copy Markdown
Contributor

@dmitrytrager Can you please rename the commit and its body to be more descriptive? Having # This is a combination of 3 commits. is not very informative about the changes being made 😞

@dmitrytrager

Copy link
Copy Markdown
Author

okay

Compare redirect_uri and grant uri without query
when doing checks from authorization code request

Fix xss by escaping tags:
content_tag body is correctly escaped when rendered even if called is
wrapped by raw

Fix CI review
@dmitrytrager

Copy link
Copy Markdown
Author

@maclover7 is it ok now?

@StupidCodeFactory

Copy link
Copy Markdown

We're getting 401's when using Doorkeeper with the omniauth gem to login which appends query params.

@maclover7 any chance to get this in?

Thanks

@nbulaj
nbulaj self-requested a review January 26, 2018 15:09
@nbulaj
nbulaj merged commit 2645f46 into doorkeeper-gem:master Jan 26, 2018
@nbulaj

nbulaj commented Jan 26, 2018

Copy link
Copy Markdown
Member

Thanks @dmitrytrager!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants