fix: ensure that token revocation is idempotent - #1778
Merged
nbulaj merged 2 commits intoAug 19, 2025
Merged
Conversation
hannahyeates
force-pushed
the
fix-make-token-revocation-idempotent
branch
from
August 18, 2025 17:15
fa576db to
cde08a9
Compare
amljk
approved these changes
Aug 18, 2025
darrunategui
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We were debugging an issue related to how we lock the access tokens table when we refresh an access token, and in this process, we found that revoking an access token is not idempotent. In the existing implementation, the
revoked_attimestamp will continue to be updated each timerevoke!is called on the same access token. Since a token can only be revoked once, this should be enforced in code.