Make sure error handling happens on a controller level opposed to action level to account for the controller being extended - #1767
Merged
Conversation
…ion level to account for the controller being extended
nbulaj
approved these changes
Apr 1, 2025
nbulaj
left a comment
Member
There was a problem hiding this comment.
I like it! Thanks!
Can we add a changelog entry please as well?
Member
|
OK I can do it my self actually, wanna to do a release soon. So thanks anyway! |
Contributor
Author
|
@nbulaj Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When extending the
TokensControllerfor any purpose, if any helper method is called and ends up raising an error, that error wasn't being handled by the controller since the rescue was happening at the action level.Turning an action level
rescueinto a controllerrescue_fromwill ensure controllers extendingTokensControllerwill have the same error handling while enabling it to keep calling the helper methods without worrying about error handling.