Allow missing client to trigger invalid client error when force_pkce is enabled - #1762
Merged
nbulaj merged 1 commit intoJan 31, 2025
Merged
Conversation
…is enabled Currently, the force_pkce handling is treating a missing client as a non-confidential client and forcibly validating the code_verifier param. This updates the conditional to only force_pkce if the client is present.
gkemmey
force-pushed
the
allow-invalid-client-when-force-pkce
branch
from
January 27, 2025 22:24
a9924b8 to
bc3310f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the force_pkce handling is treating a missing client as a non-confidential client and forcibly validating the code_verifier param. This updates the conditional to only force_pkce if the client is present.