Fix the error message for force_pkce - #1755
Merged
Merged
Conversation
Bug When the `force_pkce` option is enabled for a public client, and the authorization code request doesn't include a code_challenge, the error message returned is "The authorization server encountered an unexpected condition which prevented it from fulfilling the request." Root cause PR doorkeeper-gem#1705 didn't add the error message in the locales. Fix Base on RFC https://datatracker.ietf.org/doc/html/rfc7636#section-4.4.1, we should return an "invalid_request" error with a proper description. I added a new entry for the error message and included a test to verify the proper message is returned.
Member
|
@mattmanning can you please take a look? 🙏 |
nbulaj
approved these changes
Dec 23, 2024
nbulaj
left a comment
Member
There was a problem hiding this comment.
+1 from my side as well, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug
When the
force_pkceoption is enabled for a public client, and the authorization code request doesn't include a code_challenge, the error message returned is"The authorization server encountered an unexpected condition which prevented it from fulfilling the request."
Root cause
[#1705] didn't add the error message in the locales.
Fix
Base on RFC https://datatracker.ietf.org/doc/html/rfc7636#section-4.4.1, we should return an "invalid_request" error with a proper description. I added a new entry for the error message and included a test to verify the proper message is returned.