Merged
Conversation
…ration request STANDARD_RIGHTS_WRITE and FILE_GENERIC_WRITE are actually read access flags. Probably the same modification should be applied to required_share()
export files woth mode=0444 as read only
Member
|
Thank you @c-klapaucius for you contribution ! Do you have other example as "hello" FUSE that could help to know the stat of dokan fuse ? |
|
Thank you. I just came to the conclusion that these incorrect flags were partially causing read-only file open issues in encfs4win, along with a coding mistake in encfs4win. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added two commits.
The first commit fixes the O_RDONLY parameter, passed to the fuse_win callbacks.
I could apply the same modification to required_share() but I cannot test it at the moment.
The second commit adds partial read-only export to the system. We definitely want to export files with mode 0444, 0111, 0544... as a read-only files.
Both commits were tested with the the "hello" FUSE sample file.