Use _malloca() for debug strings to avoid buffer overflows#84
Merged
Liryna merged 1 commit intodokan-dev:masterfrom Oct 10, 2015
Merged
Use _malloca() for debug strings to avoid buffer overflows#84Liryna merged 1 commit intodokan-dev:masterfrom
Liryna merged 1 commit intodokan-dev:masterfrom
Conversation
While the sprintf_s functions are supposed to protect from buffer overflows and other errors, they still raise an exception if the buffer is too small, so any debug string longer than 512 characters still crashes the program. In practice, this limit is exceeded very easily, for example, when matching a file name with a length of MAX_PATH against itself. Instead of just increasing the buffer size and/or using snprintf, I prefer to use a combination of _vscwprintf() and _malloca()/_freea(), which computes the final length and then calls either alloca() for strings below 1024 bytes or malloc() for longer ones. This makes sure the string always gets shown in full (well, except for the unlikely case of a malloc() failure) and should eliminate this bug class without impacting performance too much.
Member
|
Thank you ! |
Liryna
added a commit
that referenced
this pull request
Oct 10, 2015
Use _malloca() for debug strings to avoid buffer overflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the sprintf_s functions are supposed to protect from buffer overflows and other errors, they still raise an exception if the buffer is too small, so any debug string longer than 512 characters still crashes the program. In practice, this limit is exceeded very easily, for example, when matching a file name with a length of MAX_PATH against itself.
Instead of just increasing the buffer size and/or using snprintf, I prefer to use a combination of _vscwprintf() and _malloca()/_freea(), which computes the final length and then calls either alloca() for strings below 1024 bytes or malloc() for longer ones. This makes sure the string always gets shown in full (well, except for the unlikely case of a malloc() failure) and should eliminate this bug class without impacting performance too much.