Skip to content

Conversation

@lorenrh
Copy link
Member

@lorenrh lorenrh commented Sep 8, 2021

Signed-off-by: Lorena Rangel [email protected]

Proposed changes

Unreleased project version (optional)

Related issues (optional)

@netlify
Copy link

netlify bot commented Sep 8, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: b76fc94

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/613f4f80e6ff93000844432c

😎 Browse the preview: https://deploy-preview-13486--docsdocker.netlify.app

> {%- include eula.md -%}
>
> [Mac with Intel chip](https://desktop.docker.com/mac/stable/amd64/67817/Docker.dmg){: .accept-eula } |
> [Mac with Apple chip](https://desktop.docker.com/mac/stable/arm64/67817/Docker.dmg){: .accept-eula }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the accept-eula classes are not needed for v4.0 and up (because docker desktop itself will ask the user to accept)

>
> [Mac with Intel chip](https://desktop.docker.com/mac/stable/amd64/Docker.dmg?utm_source=docker&utm_medium=webreferral&utm_campaign=docs-driven-download-mac-amd64){: .button .primary-btn }
> [Mac with Apple chip](https://desktop.docker.com/mac/stable/arm64/Docker.dmg?utm_source=docker&utm_medium=webreferral&utm_campaign=docs-driven-download-mac-arm64){: .button .primary-btn }
> {%- include eula.md -%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the eula include as well 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I just copied pasted from the last part! 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the older releases did not have the "accept agreement" in the installer, which is why it was added in the docs. Now that all new binaries we ship have this, I think we can remove it for the new downloads, so if could be simplified to:

> Download Docker Desktop
>
> [Mac with Intel chip](https://desktop.docker.com/mac/stable/amd64/67817/Docker.dmg) |
> [Mac with Apple chip](https://desktop.docker.com/mac/stable/arm64/67817/Docker.dmg)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. We don't need the EULA class for 4.0 and higher releases

@lorenrh lorenrh force-pushed the relNotes-4.0.1 branch 2 times, most recently from e228bf9 to 360daec Compare September 9, 2021 09:14
@crazy-max
Copy link
Member

crazy-max commented Sep 9, 2021

@lorenrh Buildx 0.6.3 is not part of this release? (fixes docker/buildx#751)

@lorenrh
Copy link
Member Author

lorenrh commented Sep 9, 2021

@crazy-max not for 4.0.1. It is planned for the 4.1.0 release.

mat007
mat007 previously approved these changes Sep 9, 2021
Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

usha-mandya
usha-mandya previously approved these changes Sep 9, 2021
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 5a6556c into docker:master Sep 13, 2021
@lorenrh lorenrh deleted the relNotes-4.0.1 branch November 2, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants