add support for external binary with provider services #12781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1173af to
49a9ce6
Compare
Signed-off-by: Guillaume Lours <[email protected]>
49a9ce6 to
ef1880b
Compare
Contributor
|
already implemented in #12777 :) |
ndeloof
reviewed
Apr 28, 2025
| plugin, err := s.getPluginBinaryPath(provider.Type) | ||
| if err != nil { | ||
| return err | ||
| if !strings.Contains(err.Error(), "Error: No such CLI plugin") { |
Contributor
Author
|
Close in favor of #12777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the capability of running command from external binaries from provider services definition.
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did