Skip to content

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Feb 17, 2025

handleImageToMount was an exact copy of handleBindToMount instead of populating the ImageOptions.

handleImageToMount was an exact copy of handleBindToMount instead of
populating the ImageOptions.

Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland added area/volumes kind/bugfix PR's that fix bugs labels Feb 17, 2025
@vvoland vvoland added this to the 28.0.0 milestone Feb 17, 2025
@vvoland vvoland self-assigned this Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (c542ad7) to head (4cc2dce).
Report is 2 commits behind head on master.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5832   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files         352      352           
  Lines       29547    29547           
=======================================
  Hits        17486    17486           
  Misses      11080    11080           
  Partials      981      981           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit b73653e into docker:master Feb 17, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants