Skip to content

Conversation

@thaJeztah
Copy link
Member

commit 71ebbb8 replaced the use of the custom "cli.Errors" type for stdlib's errors.Join, however it made a mistake by calling errors.Join for each error occurred, which "nests" each error instead of putting each error at the same level.

Thanks to Paweł Gronowski for spotting this on the pull request

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Feb 1, 2025
@thaJeztah thaJeztah requested a review from vvoland February 1, 2025 11:26
@thaJeztah thaJeztah self-assigned this Feb 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (4808d1b) to head (37b25f2).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5779   +/-   ##
=======================================
  Coverage   59.42%   59.42%           
=======================================
  Files         347      347           
  Lines       29398    29400    +2     
=======================================
+ Hits        17469    17471    +2     
  Misses      10957    10957           
  Partials      972      972           

commit 71ebbb8 replaced the use of the
custom "cli.Errors" type for stdlib's errors.Join, however it made a
mistake by calling errors.Join for each error occurred, which "nests"
each error instead of putting each error at the same level.

Thanks to Paweł Gronowski for spotting this on the [pull request][1]

[1]: docker@71ebbb8#r1810257735

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the fix_plugin_multierr branch from 7c264e5 to 37b25f2 Compare February 3, 2025 12:08
@thaJeztah thaJeztah merged commit 919bd6a into docker:master Feb 3, 2025
89 checks passed
@thaJeztah thaJeztah deleted the fix_plugin_multierr branch February 3, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants