cli/formatter: fix unbracketed IPv6 addrs #5468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 964155c tried to enclose all IPv6 addresses within brackets but missed some cases. This commit fixes that, and adds a few test cases. Signed-off-by: Albin Kerouanton <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5468 +/- ##
==========================================
- Coverage 60.93% 59.74% -1.20%
==========================================
Files 304 345 +41
Lines 21348 23431 +2083
==========================================
+ Hits 13009 13999 +990
- Misses 7409 8458 +1049
- Partials 930 974 +44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Follow-up:
Commit 964155c tried to enclose all IPv6 addresses within brackets but missed some cases. This commit fixes that, and adds a few test cases.
- How I did it
- How to verify it
New unit tests.
- Description for the changelog