info: stop printing "Expected" commits #5422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5422 +/- ##
==========================================
- Coverage 59.78% 59.77% -0.01%
==========================================
Files 345 345
Lines 23394 23385 -9
==========================================
- Hits 13985 13978 -7
+ Misses 8438 8437 -1
+ Partials 971 970 -1 |
The `Commit` type was introduced in moby/moby@2790ac6, to assist triaging issues that were reported with an incorrect version of runc or containerd. At the time, both `runc` and `containerd` were not yet stable, and had to be built from a specific commit to guarantee compatibility. We encountered various situations where unexpected (and incompatible) versions of those binaries were packaged, resulting in hard to trace bug-reports. For those situations, a "expected" version was set at compile time, to indicate if the version installed was different from the expected version; docker info ... runc version: a592beb5bc4c4092b1b1bac971afed27687340c5 (expected: 69663f0bd4b60df09991c08812a60108003fa340) Both `runc` and `containerd` are stable now, and docker 19.03 and up set the expected version to the actual version since moby/moby@c65f0bd and 23.0 did the same for the `init` binary moby/moby@b585c64, to prevent the CLI from reporting "unexpected version". In short; the `Expected` fields no longer serves a real purpose, so we should no longer print it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
7bdb927 to
88ca4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
The
Committype was introduced in moby/moby@2790ac6, to assist triaging issues that were reported with an incorrect version of runc or containerd. At the time, bothruncandcontainerdwere not yet stable, and had to be built from a specific commit to guarantee compatibility.We encountered various situations where unexpected (and incompatible) versions of those binaries were packaged, resulting in hard to trace bug-reports. For those situations, a "expected" version was set at compile time, to indicate if the version installed was different from the expected version;
Both
runcandcontainerdare stable now, and docker 19.03 and up set the expected version to the actual version since moby/moby@c65f0bd and 23.0 did the same for theinitbinary moby/moby@b585c64, to prevent the CLI from reporting "unexpected version".In short; the
Expectedfields no longer serves a real purpose, so we should no longer print it.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)