Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 27, 2023

Signed-off-by: David Karlsson [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #3991 (dc4d73f) into master (645395c) will not change coverage.
The diff coverage is n/a.

❗ Current head dc4d73f differs from pull request most recent head 1e3622c. Consider uploading reports for the commit 1e3622c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3991   +/-   ##
=======================================
  Coverage   59.20%   59.20%           
=======================================
  Files         287      287           
  Lines       24697    24697           
=======================================
  Hits        14621    14621           
  Misses       9192     9192           
  Partials      884      884           

@dvdksn dvdksn marked this pull request as ready for review January 27, 2023 15:13
@dvdksn dvdksn requested a review from thaJeztah as a code owner January 27, 2023 15:13
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, actually; could you squash the commits, @dvdksn ?

@dvdksn dvdksn force-pushed the docs/refactor-docs-dir branch from dc4d73f to 1e3622c Compare January 31, 2023 05:33
@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 31, 2023

oh, actually; could you squash the commits, @dvdksn ?

done!

@thaJeztah thaJeztah added this to the 23.0.0 milestone Jan 31, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants