deprecate registry v2 schema 1 #1956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 310 310
Lines 21800 21800
=======================================
Hits 12367 12367
Misses 8518 8518
Partials 915 915 |
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 310 310
Lines 21800 21800
=======================================
Hits 12367 12367
Misses 8518 8518
Partials 915 915 |
tiborvass
reviewed
Jun 18, 2019
tiborvass
reviewed
Jun 18, 2019
thaJeztah
requested changes
Jun 19, 2019
Member
|
prepared backport; #1960 |
justincormack
approved these changes
Jun 21, 2019
tiborvass
reviewed
Jun 21, 2019
tiborvass
reviewed
Jun 21, 2019
|
Please sign your commits following these rules: $ git clone -b "deprecate" [email protected]:andrewhsu/cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842356989440
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Collaborator
|
@andrewhsu I can't modify your branch, did you keep the "allow edits from maintainers" checkbox when you opened the PR ? |
Co-Authored-By: Sebastiaan van Stijn <[email protected]> Signed-off-by: Andrew Hsu <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
|
squashed the commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added deprecation notice for registry v2 schema 1
related: moby/moby#39365