bake: test empty override #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Dec 18, 2024
Member
tonistiigi
left a comment
There was a problem hiding this comment.
These are not testing the return value of ReadTargets like the old one did (same can be added to override case).
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Jonathan A. Sternberg <[email protected]>
300b21a to
1e992b2
Compare
Collaborator
Author
|
@tonistiigi done and I also added a check to make sure that |
tonistiigi
approved these changes
Dec 18, 2024
This was referenced Jan 21, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of afc9ceb.