tests: test with buildx experimental #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cfca09 to
c611faf
Compare
crazy-max
commented
Apr 2, 2024
Comment on lines
281
to
311
| if isExperimental() { | ||
| t.Skip("build details link not displayed in experimental mode when build fails") | ||
| } |
Member
Author
There was a problem hiding this comment.
Build details link is not displayed for a build that fails through controller: https://github.com/docker/buildx/actions/runs/8522265808/job/23342157852?pr=2376#step:7:771
Might be related to result handler, will check in follow-up
tonistiigi
reviewed
Apr 2, 2024
c611faf to
de970fa
Compare
Merged
tonistiigi
approved these changes
Apr 4, 2024
de970fa to
792876e
Compare
Signed-off-by: CrazyMax <[email protected]>
792876e to
b61b29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2368