bake: avoid evaluating parent targets before child LLB loaded #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way buildkit cache works if you have request with external cache, if some vertices from the request have already been evaluated and are available in the shared graph BuildKit will not load cache keys from external source for such vertices. This may mean that children of such vertices will not load cache because there isn't a cache path through the parent. To work around it, wait before child definition is loaded before evaluating the parent. Signed-off-by: Tonis Tiigi <[email protected]>
This was referenced Feb 21, 2024
crazy-max
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way buildkit cache works if you have request with external cache, if some vertices from the request have already been evaluated and are available in the shared graph BuildKit will not load cache keys from external source for such vertices. This may mean that children of such vertices will not load cache because there isn't a cache path through the parent.
To work around it, wait before child definition is loaded before evaluating the parent.
fix #2144