[v0.10] cherry-picks for v0.10.1 #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crazy-max
commented
Jan 26, 2023
- fix the directory of the buildx binary #1502
- ci: fix typo in docs-release workflow #1515
- docs: fix broken link in buildx_bake CLI reference #1516
- build: mark capabilities request as internal #1538
- rm: do not check for context builders when removing inactive #1547
- imagetools: silence intoto warnings #1549
- Refactor BuildWithResultHandler to simplify concurrency usage #1504
- build: set remote origin url #1548
Signed-off-by: Batuhan Apaydın <[email protected]> (cherry picked from commit edb16f8)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 523a16a)
Signed-off-by: David Karlsson <[email protected]> (cherry picked from commit ba8fa6c)
So it doesn't show up in the History API. Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit be55b41)
This change has been introduced in e7b5ee7 but we should not check context builders when removing inactive ones. Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 6cd0c11)
Signed-off-by: Justin Chadwell <[email protected]> (cherry picked from commit 7145e02)
Signed-off-by: Justin Chadwell <[email protected]> (cherry picked from commit 347417e)
Signed-off-by: Justin Chadwell <[email protected]> (cherry picked from commit 1180d91)
Using the syncronization primitive, we can avoid needing to create a separate wait group. This allows us to sidestep the issue where the wait group could be completed, but the build invocation functions had not terminated - if one of the functions was to terminate with an error, then it was possible to encounter a race condition, where the result handling code would begin executing, despite an error. The refactor to use a separate error group which more elegantly handles the concept of function returns and errors, ensures that we can't encounter this issue. Signed-off-by: Justin Chadwell <[email protected]> (cherry picked from commit 8b7aa1a)
Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit c1058c1)
Member
Author
|
@jedevc @tonistiigi When BuildKit 0.11.2 is released, will open a PR to vendor on Buildx and cherry-pick here. |
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit f6da7ee)
Member
|
added #1559 |
tonistiigi
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.