Move async to graphql-java-async project #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved all async specific changes to graphql-java-async project.
Owner
|
@bmsantos what do you think about waiting for graphql-java#336 first? |
Author
|
That's a possibility. But, in my opinion, I would separate the two. What I mean is that I would continue as it is. Then, whenever graphql-java#336 is implemented, create a new issue to move graphql-java-async into the new multi-module project. |
Author
|
This will allow you to start closing the open async tickets like this one and the one open in graphql-java graphql-java#283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all async specific changes to graphql-java-async project.