Repository navigation
replace collectException(dirEntry()) idiom - #64
Merged
Merged
Conversation
- it used exceptions to handle non-exceptional situations only to avoid a stat call
Member
Author
andralex
added a commit
that referenced
this pull request
Jun 18, 2013
replace collectException(dirEntry()) idiom
Member
|
We must undo this. I've done extensive measurements and stat() calls are REALLY expensive at least on Unixen. Essentially minimizing stat calls in large systems is a sure path to optimization. I am sorry I've pulled this. |
Member
Author
|
In fact this didn't change the number of stat calls (2 per isDir check) because the constructor of |
Member
|
yah I saw that bug in DirEntry - what a drag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
situations only to avoid a stat call
NB:
The fact that it can't be done in an optimal way is really an API issue of std.file.dirEntry.