Use cc_wrapper to shorten library and include paths and rpaths - #2791
Merged
Conversation
aherrmann-da
force-pushed
the
use-cc-wrapper
branch
from
September 6, 2019 08:55
f927731 to
bc4ffc6
Compare
Updates to latest rules_haskell master and adds the cc_wrapper PR as a patch, see tweag/rules_haskell#1039.
When using `haskell_cabal_library` GHC constructs unnecessarily long include directories which can quickly overflow the maximum command-line length. This patch avoids the issue by normalizing include paths.
aherrmann-da
force-pushed
the
use-cc-wrapper
branch
from
September 6, 2019 09:40
bc4ffc6 to
c1cd1f4
Compare
aherrmann-da
force-pushed
the
use-cc-wrapper
branch
from
September 9, 2019 14:00
d8d8243 to
a80300d
Compare
aherrmann-da
force-pushed
the
use-cc-wrapper
branch
from
September 9, 2019 15:09
a80300d to
db037d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns out to be necessary when using
stack_snapshotinstead of Hazel. The reason is that GHC does not normalize or deduplicate library or include paths defined by package configurations in the package database. See tweag/rules_haskell#1062Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.