Support for multi-platform builds - #18
Closed
Juan Zuluaga (juzuluag) wants to merge 7 commits into
Closed
Conversation
Contributor
Author
|
Closing since too many conflicts after merge. Replaced with #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item ID
Description
Enhance
devcontainerCLI build command by adding an option to build multi-platform container images and to push them to a container registry.devcontainer build command will be enhanced with the following arguments:
--buildx enable to use buildx arguments [boolean][default: false]
--platform value1, value2. Comma delimited string with platform types [string].
i.e. value: linux/amd64,linux/arm64
--push push to a container registry [boolean] [default: false]
--load load builded image to images [boolean] [default: false]
PR Checklist
Does this introduce a breaking change?
Testing
Manual testing:
List manifest from container registry
docker buildx imagetools inspect dockerhubuname/test1:v1 Name: docker.io/dockerhubuname/test1:v1 MediaType: application/vnd.docker.distribution.manifest.list.v2+json Digest: sha256:00b62d385953096b5b09ba1458d0e2467b53b3c6d2409958a67eabd68f4fa0a0 Manifests: Name: docker.io/dockerhubuname/test1:v1@sha256:a18591ab9c4d416b9ee5b86c1b66c5ff9b89f8b8b522bc3d26db1395bd736f34 MediaType: application/vnd.docker.distribution.manifest.v2+json Platform: linux/arm64 Name: docker.io/dockerhubuname/test1:v1@sha256:4ae8b07ea9a8c61da4a06548d758fc27709408b79d52d293bdc0edb940041576 MediaType: application/vnd.docker.distribution.manifest.v2+json Platform: linux/amd64Other information or known dependencies
n/a