Merged
Conversation
8d7722a to
f738868
Compare
There was a problem hiding this comment.
Pull request overview
Adds additional Go hygiene checks to the build-codeql CI job to catch dependency drift, formatting issues, and suspicious-but-compilable code earlier in PRs.
Changes:
- Add
go mod tidy -diffto fail CI whengo.mod/go.sumare out of sync. - Add a
gofmtvalidation step that prints diffs for unformatted files (excludingvendor/). - Add
go vet ./...aftergo buildto catch issues with build cache already warmed.
13b7d31 to
81dee31
Compare
Add a dedicated lint job to ci.yml running on ubuntu-latest: - yamllint (moved from standalone yamllint.yml workflow) - go mod tidy -diff - gofmt check (excluding vendor/) with diff output on failure - go build ./... (for clearer compile errors) - go vet ./... (reuses build cache) These checks are platform-independent so they don't need to run in the build-codeql matrix across all three OSes.
81dee31 to
bc86e97
Compare
jeffwidman
commented
Mar 13, 2026
|
|
||
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest |
Member
Author
There was a problem hiding this comment.
I considered ubuntu-slim, but since this has go build (required for go vet) I decided to stick with ubuntu-latest...
Not a big deal either way.
JamieMagee
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dedicated lint job to ci.yml running on ubuntu-latest:
go mod tidy -diff— fails if go.mod/go.sum are out of syncgofmtcheck — fails if any non-vendor Go files are unformatted, showing the diffgo build ./...— for clearer compile error messagesgo vet ./...— catches suspicious but compilable code (reuses build cache)These checks are platform-independent so they run once on Ubuntu.
Also deletes the standalone yamllint.yml workflow since it is now consolidated here.