Skip to content
This repository was archived by the owner on Jan 3, 2021. It is now read-only.

python 2 and python 3 compatibility fixes#45

Merged
eliangcs merged 1 commit intodbcli:masterfrom
adnanyaqoobvirk:master
Apr 28, 2016
Merged

python 2 and python 3 compatibility fixes#45
eliangcs merged 1 commit intodbcli:masterfrom
adnanyaqoobvirk:master

Conversation

@adnanyaqoobvirk
Copy link
Contributor

I have faced few errors while running vcli in python3.3, I have fixed them to the best of my knowledge. I have tested it on both python 2.7 and python 3.3 and it is working.

@eliangcs
Copy link
Member

vertica-python, which vcli depends on, does not support Python 3, so I don't think you can run vcli on Python 3 without modifying vertica-python. Did you change vertica-python?

@adnanyaqoobvirk
Copy link
Contributor Author

Yes, I did and I have submitted the pull request here:

https://github.com/FredrikAppelros/vertica-python

Who has done most of the work porting the vertica-python for python3. If his pull request get's accepted in the main repository then the python3 support will be available officially. However, changes in this pull request ensures that this module is compatible with both python 2 and 3.

@eliangcs
Copy link
Member

I see. I think we can merge this pull request after vertica/vertica-python#91 gets accepted.

@eliangcs
Copy link
Member

vertica-python just released 0.6.0, which supports Python 3! I'll merge this PR, but it needs more work to make the tests pass. We'll also need to update .travis.yml and setup.py.

@eliangcs eliangcs mentioned this pull request Apr 28, 2016
@eliangcs eliangcs merged commit 03eefc7 into dbcli:master Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants