[DRAFT] add more logging for populate()

[ttngu207]

No description provided.

[dimitri-yatsenko]

Suggested change

	logger.info("Start populating TABLE: {} - KEY: {}".format(self.target.table_name, key))
	logger.info(f"Making {self.target.table_name}: {key}")

[dimitri-yatsenko]

Suggested change

	logger.info("Error in populating TABLE: {} - KEY: {}\n\t Error Message: {}".format(self.target.table_name, key, error_message))
	logger.info(f"Error making {self.target.table_name}: {key} - {error_message}")

[dimitri-yatsenko]

Suggested change

	logger.info("Successful in populating TABLE: {} - KEY: {}".format(self.target.table_name, key))
	logger.info(f"Success populating {self.target.table_name}: {key}")

[dimitri-yatsenko]

Do we really want to log so much?

[ttngu207]

This is to facilitate the "notification" mechanism, e.g. having clear and distinct log messages so that it can be parsed easily by some custom loghandler and then fed into some notification scheme (e.g. send emails, slack messages, etc.)

Hence I purposely have the log message being a bit wordy but hopefully distinctive - Start populating TABLE, Error in populating TABLE, etc. - so that it is easy to parse the log later.

Making... or Error making... may just be too generic.

[guzman-raphael]

These logs should be debug so that that the default behavior is not too verbose. Additionally, agree with @dimitri-yatsenko's point on making them a bit more concise. However, to help with parsing/automation, we can use the making [key] -> [table] - [error] syntax to help us indicate these events; it is currently not being used anywhere else. So in summary:

Making {key} -> {self.target.table_name} 
Error making {key} -> {self.target.table_name} - {error_message}
Success making {key} -> {self.target.table_name}

Also, since this is superseded by #1031, closing this.