Skip to content

Conversation

@johnmacnamararseg
Copy link

@johnmacnamararseg johnmacnamararseg commented May 3, 2023

fix for #634

replaces deprecated DEFAULT_METHOD_WHITELIST in urllib3>=2.0 with DEFAULT_ALLOWED_METHODS.

DEFAULT_ALLOWED_METHODS is supported in the latest versions of urrlib3 and requests

@johnmacnamararseg
Copy link
Author

johnmacnamararseg commented May 3, 2023

I rebuilt the whl with changes and ran cli calls against databricks and this seems to fix the issue

Copy link

@jakepeacock-bh jakepeacock-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we faced this too. thanks for the find

@ViktorDronov
Copy link

is it possible fix this issue somehow because for now this functionality is broken already?

@alhuelamo
Copy link

@ViktorDronov #634 As a patch, you can pin a urllib version, but certainly, this should be fixed sooner than later here.

@kolomietsdv
Copy link

It could be backward incompatible with urllib version < 2, so maybe it makes sense to specify the urllib version as well

@ViktorDronov
Copy link

ViktorDronov commented May 7, 2023

@pietern
Copy link
Contributor

pietern commented May 8, 2023

Thanks for putting up the patch. The same fix (with major version restriction) was merged in #637.

We just released version 0.17.7 to PyPI which includes this fix.

@pietern pietern closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants