Skip to content

Conversation

@pietern
Copy link
Contributor

@pietern pietern commented Mar 13, 2023

Adds the webhook_notifications field to JobsService.

This change also renames the argument name_filter to name to match the API.

FYI @dinowernli

This change renames the argument `name_filter` to `name` to match the API.
@pietern
Copy link
Contributor Author

pietern commented Mar 13, 2023

Compat failure is due to name_filter -> name rename. Can be ignored.

Copy link
Contributor

@dinowernli dinowernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pietern pietern merged commit dae9d9a into main Mar 21, 2023
@pietern pietern deleted the jobs-missing-fields branch March 21, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants