-
Notifications
You must be signed in to change notification settings - Fork 233
Allow JSON matching API endpoint for reset job #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 60.93% // Head: 75.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
===========================================
+ Coverage 60.93% 75.76% +14.83%
===========================================
Files 55 55
Lines 4669 4906 +237
===========================================
+ Hits 2845 3717 +872
+ Misses 1824 1189 -635
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. LGTM otherwise.
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afberg Thanks!
Ensures that users copying over API calls into the cli for the jobs/reset endpoint don't encounter errors.
Any user calling the reset cli with the
new_settingsproperty at the root level e.g.will no longer get an error. Only calls where the
new_settingsproperty is present at the root level are affected.This PR aims to make the CLI and API more consistent without adding any breaking changes.
(This PR is a follow-up to #524)