-
Notifications
You must be signed in to change notification settings - Fork 233
Change Create Recipient CLI to use global metastore ID #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81de72b to
1119681
Compare
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 60.72% 60.72%
=======================================
Files 55 55
Lines 4692 4692
=======================================
Hits 2849 2849
Misses 1843 1843
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Do we still need to fix public API even if sharing code is useless today? |
adamcain-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The databricks-cli changes LGTM, though I know nothing of the underlying CreateRecipient API change. Should a delta-sharing person also review?
zhuansunxt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the UI we use the term sharing identifier. I think the rationale behind that is we want to be more abstract so we can change the format later. Let's keep it consistent in the CLI. (probably too late to migrate REST API)
zhuansunxt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore the API compatibility test as these functions are unlikely to already be in use.
Sharing code is not used anymore.
Tested locally.