Skip to content

Conversation

@wchau
Copy link
Contributor

@wchau wchau commented Aug 1, 2022

No description provided.

@wchau wchau requested a review from adamcain-db August 1, 2022 23:35
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #528 (7b3635e) into main (642b6ba) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   60.88%   60.91%   +0.03%     
==========================================
  Files          55       55              
  Lines        4673     4677       +4     
==========================================
+ Hits         2845     2849       +4     
  Misses       1828     1828              
Impacted Files Coverage Δ
databricks_cli/unity_catalog/perms_cli.py 0.00% <0.00%> (ø)
databricks_cli/pipelines/cli.py 96.34% <0.00%> (+0.91%) ⬆️
databricks_cli/click_types.py 88.59% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642b6ba...7b3635e. Read the comment docs.

Copy link
Contributor

@adamcain-db adamcain-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
BTW, a couple weeks ago I asked @allisonwang-db about adding FUNCTION and she said they didn't have a use case yet for adding that support to databricks-cli.

@wchau
Copy link
Contributor Author

wchau commented Aug 2, 2022

LGTM! BTW, a couple weeks ago I asked @allisonwang-db about adding FUNCTION and she said they didn't have a use case yet for adding that support to databricks-cli.

We also have share, recipient, and provider, but don't need permissions for them yet.

@wchau wchau requested review from fjakobs and pietern August 2, 2022 00:37
Copy link
Contributor

@fjakobs fjakobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjakobs
Copy link
Contributor

fjakobs commented Aug 4, 2022

@wchau wchau force-pushed the metastore_create_privilege branch from 7b3635e to f9c094b Compare August 4, 2022 17:00
@wchau
Copy link
Contributor Author

wchau commented Aug 4, 2022

@fjakobs Done!

@fjakobs fjakobs merged commit ecfee34 into databricks:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants