Revert "Sample - Fix exports from Workspace to Windows FS (#448)" #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormwindy
approved these changes
Jul 13, 2022
Contributor
stormwindy
left a comment
There was a problem hiding this comment.
LGTM, be aware that the issue this PR was trying to fix should still be resolved which was incompatibility between windows, unix path names.
Contributor
Author
|
Thanks, @stormwindy. Is there an issue for this already? If not, please create one with the exact incompatibility you're thinking about. E.g. is this just about forward vs backward slash or more incompatible characters, etc. |
Contributor
|
@pietern There used to be an issue from a contributor. However, I couldn't find it again (it was about downloading job results from what I remember where folder names weren't compatible (can't really remember!!)). There is another one recently created issue about characters not being compatible: #366 |
Contributor
Contributor
Author
|
@stormwindy Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c695b8d.
See #448 (comment).