-
Notifications
You must be signed in to change notification settings - Fork 233
Add flag for UC get-effective-permissions #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for UC get-effective-permissions #511
Conversation
| @click.option('--external-location', cls=OneOfOption, default=None, | ||
| one_of=PERMISSIONS_OBJ_TYPES, | ||
| help='Name of the external location of interest') | ||
| @click.option('--effective', '-e', is_flag=True, default=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The short form option doesn't seem like a good idea, since it naturally conflicts with --external-location.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I removed the -e flag (and added some help text) for that command.
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 61.08% 60.95% -0.14%
==========================================
Files 55 55
Lines 4662 4672 +10
==========================================
Hits 2848 2848
- Misses 1814 1824 +10
Continue to review full report at Codecov.
|
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamcain-db. For future PRs, having a couple of tests to confirm the intended behavior would be nice. There are no tests for the entire UC subcommand at the moment.
Thanks @pietern. Yep, adding tests for |
get-permissionsCLI which causes it to use UC'sgetEffectivePermissionsendpoint.