-
Notifications
You must be signed in to change notification settings - Fork 233
Regenerate service.py #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we minimize the changes in the signatures? Or we need to bump version & declare it as a breaking change
|
Thanks for taking a look @alexott. Good points regarding kwarg order. I did some investigation:
I think we should consider stable named parameter ordering at 1.0. For now, I think we're safe to call it out in the release notes and bump to 0.18. |
Ran `black -S --line-length 100`.
|
I did some more investigation and found a couple call sites that use positional parameters and would be broken by this change. Unfortunately we cannot start forcing keyword arguments (e.g. with All new keyword arguments are appended so none of the existing call sites should break. |
|
@nfx Filed follow ups for the issues not in scope here. |
Codecov Report
@@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 61.10% 61.08% -0.02%
==========================================
Files 55 55
Lines 4664 4662 -2
==========================================
- Hits 2850 2848 -2
Misses 1814 1814
Continue to review full report at Codecov.
|
First pass to ensure better completeness of the arguments to the methods in
service.py.