-
Notifications
You must be signed in to change notification settings - Fork 17
Add support for reporting skipped tests #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New in Python 2.7+ and/or unittest2. This should not break anything when using older versions of unittest, however, since the new routines will simply be ignored. The skip values will still be reported, but they will be universally zero (since the routines to count them will never get called).
|
@eestrada My apologies for the delay in following up on this. Can you resolve the conflicts? I can then do a review and merge it in. |
|
@dash0002 I don't have a lot of time right now, but I'll see what I can do. Once I've had a chance to look at it, I'll let you know if I can't dedicate all the time needed to get this merged. |
|
Hello, I also wanted this feature. How can I help to check the conflicts and get this merged ? |
|
@haknaton The conflicts just need to be reviewed (branch can't be merged currently), then we can do a code review and merge it in. |
|
@haknaton Both our codebases were forked from was the original at tungwaiyip/HTMLTestRunner. @dash0002's and my codebase have since diverged enough that git can't automatically resolve the conflicts. You would need to pull from both our repos as remotes and then attempt to merge the changes. |
|
Also, @dash0002, after reviewing the changes some, I have determined that I don't have the time right now to dedicate to merging this. I could maybe get to it in 2-3 weeks once things calm down a bit with work, but that would probably be the soonest I could address it. On a side note, I really wish github would just post a link showing the conflicts that can't be resolved. It would save a ton of time in circumstances like this. Maybe this already exists and I just don't know how to use it. |
|
@eestrada Completely understood. No rush from my side. Quick heads up... My fork is actually a Python 3 compatible fork which probably explains the large amount of conflicts. When you do get time, it might be better to branch directly from dash0002/HTMLTestRunner and cherry pick in. @haknaton if you're in a rush or @eestrada is open to it, maybe you can do the same and make a new branch and review side by side/cherry pick in. I'd be happy to help. |
|
#4 is a rebase of this pull request on the latest changes |
Skipped tests are new in Python 2.7+ and/or
unittest2. This should not break anythingwhen using older versions of
unittest, however, since the new routineswill simply be ignored. The skip values will still be reported, but they
will be universally zero (since the routines to count them will never
get called).
Also, change
printstatement into new Python 3 styleprintfunction call.