Convert to using the Elixir thrift parser from pinterest/elixir-thrift #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of commented-out
(It would no longer be needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pinterest/elixir-thrift#thrift-idl-parsing
This would be great to use because it avoids needing to have the thrift binary installed, and it means working directly with Elixir types rather than translating from the thrift-generated Erlang code. It also makes it possible to resolve #10 which I could not resolve using the Erlang route.
The code is currently really rough and needs refactoring badly, but the proof of concept is there. I intend to refactor it heavily.