Skip to content

Conversation

@roy-coder
Copy link
Contributor

@roy-coder roy-coder commented Sep 30, 2021

Converting Knex to a peer dependency would allow the usage of newer Knex versions.

@cvburgess
Copy link
Owner

Agree with this 100% and did this originally but npms inconsistent handling of peerDeps pre v7 was a major issue.

Please add a note to the readme about peerDeps and npm v6 vs v7 to the readme to prevent an influx of github issues.

@cvburgess cvburgess changed the title Convert Knex to a peer dependency 1.6.0 Convert Knex to a peer dependency Oct 4, 2021
@cvburgess cvburgess merged commit 2804652 into cvburgess:main Oct 4, 2021
@cvburgess
Copy link
Owner

This is now available via NPM ([email protected])

Thanks @roy-coder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants