Skip to content

Conversation

@tab00
Copy link
Contributor

@tab00 tab00 commented Feb 7, 2019

In case raw query result transformation to array is needed.

The result of a Knex raw query on a PostgresSQL database does not return an array, so transformation is required.
Other cases may need to be added for other databases.
Transformation is not required if the database is SQLite.

In case raw query result transformation to array is needed.
@tab00
Copy link
Contributor Author

tab00 commented Feb 19, 2019

Have you looked at this yet?

@cvburgess
Copy link
Owner

Yes, I have seen this, it just needs some tweaks. Sorry, I have a full-time job, so this is sometimes slower than I would like.

@cvburgess
Copy link
Owner

@tab00 I made some structural changes, linted the codebase, and fixed and listed some other DB clients we are currently not testing.

Do you have any time to look into those other DB configurations? The Knex repo should have mocks so you don't need to actually set those databases up.

@tab00
Copy link
Contributor Author

tab00 commented Feb 20, 2019

I'm actually extremely busy too, so don't have time to experiment with other DBs unless in future I eventually need to for my work. I think we can leave further changes to others who have a need for this package to work with the SQL DBs that they are currently using.

@cvburgess
Copy link
Owner

I will attempt to do some light testing.

Will you please open a new issue for your caching problem?

This PR does not have any fixes for that, nor have I confirmed it is even an issue.

@cvburgess
Copy link
Owner

closes #9

@cvburgess cvburgess merged commit 9b7639d into cvburgess:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants