fix(networking): correct what disabledPackages does to ouroboros - #683
Open
Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Open
fix(networking): correct what disabledPackages does to ouroboros#683Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Aleksei Sviridkin (lexfrei) wants to merge 1 commit into
Conversation
Aleksei Sviridkin (lexfrei)
requested review from
Andrei Kvapil (kvaps),
Timofei Larkin (lllamnyp),
myasnikovdaniil and
Timur Tukaev (tym83)
as code owners
September 6, 2026 22:50
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12 tasks
The host disable sequence offered bundles.disabledPackages as an alternative to `kubectl delete package.cozystack.io cozystack.ouroboros` and promised it reached the same place: helm uninstall, the chart's pre-delete hook, a patched kube-system/coredns. Neither half holds. The list is read in exactly one place, the platform chart's package helper, where it gates whether the Package document gets emitted at all. Every Package that is emitted carries an unconditional helm.sh/resource-policy: keep, so Helm leaves behind a Package it has stopped rendering. The live Package keeps the HelmRelease it owns, ouroboros keeps running, and the pre-delete hook never fires. The keep annotation was added in v1.1.5 precisely so that disabling a package stops deleting it, so the sentence described behaviour that had been gone for several releases. Deleting the Package CR remains the only step that reaches the hook, which the page already told operators to run. Same line in next, v1.4, v1.5 and v1.6. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
Aleksei Sviridkin (lexfrei)
force-pushed
the
fix/disabled-packages-ouroboros
branch
from
September 6, 2026 22:52
483bfe6 to
f7df68a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disable sequence said an operator reaches the ouroboros cleanup hook either by deleting the Package CR or by putting the name in
bundles.disabledPackages. The second one does not work.bundles.disabledPackagesis read in one place, the platform chart's package helper, and all it does there is decide whether the Package document gets emitted. Every emitted Package carries an unconditionalhelm.sh/resource-policy: keep, so Helm leaves behind a Package it has stopped rendering. The Package stays, so does the HelmRelease it owns, ouroboros keeps running, and the pre-delete hook that strips the rewrite block fromkube-system/corednsnever fires. Follow the old wording and the disable looks clean while the rewrite is still live.That annotation landed in v1.1.5 so that disabling a package stops deleting it, several releases before the oldest version this page exists in.
cozystack/cozystack#4098 fixes the same claim in the platform values and the render guard message.
hugo --gc --minifybuilds clean.hack/check-i18n.shexits 1, but the four stale-translation errors are oncontent/{de,hi,ru,zh-cn}/_index.mdand are already on main, so i18n-lint will be red for something this PR did not touch.