Skip to content

Conversation

@KacerCZ
Copy link
Contributor

@KacerCZ KacerCZ commented Jun 27, 2019

This change allows installation of Codeception 3.
Version 3.0.2 is used because this version has fixed support for PHPUnit 8.2.

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jun 27, 2019

The problem in Travis is related to Phpstan - probably because this package uses Nette 2.4 but Phpstan installs Nette 3.0.

@enumag
Copy link
Collaborator

enumag commented Jun 27, 2019

Yes, you need to upgrade to Nette 3.0 as well. Also it's most likely not worth it to allow installation of Codeception 2.x or Nette 2.x.

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jun 27, 2019

My intention was to enable upgrade only Codeception without upgrading Nette.

Another problem is with Symfony 4.3 - phpstan reports 'Class Contributte\Codeception\Connector\NetteConnector extends deprecated class Symfony\Component\BrowserKit\Client. '

For Symfony 4.3 should be used class Symfony\Component\BrowserKit\AbstractBrowser but it is not available in older versions and also this package does not constraints used Symfony version.

@enumag
Copy link
Collaborator

enumag commented Jun 27, 2019

You can just add that to ignoredErrors in phpstan.neon.

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jun 27, 2019

OK, error is now ignored and Nette used for PHPStan is same as Nette for this package.

@f3l1x f3l1x merged commit 0671e71 into contributte:master Jun 28, 2019
@f3l1x
Copy link
Member

f3l1x commented Jun 28, 2019

Thanks. 👍

@KacerCZ KacerCZ deleted the codeception-3 branch July 1, 2019 05:39
@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jul 1, 2019

Also thanks.
Can you release new version with this PR, please?

@mabar
Copy link
Contributor

mabar commented Jul 1, 2019

Yup, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants