cleanup: run go fix on pkg/machine for windows#28585
Open
jaitjacob wants to merge 1 commit intocontainers:mainfrom
Open
cleanup: run go fix on pkg/machine for windows#28585jaitjacob wants to merge 1 commit intocontainers:mainfrom
jaitjacob wants to merge 1 commit intocontainers:mainfrom
Conversation
Signed-off-by: jait jacob <jai8.jacob@gmail.com>
Member
|
LGTM |
Honny1
approved these changes
Apr 27, 2026
Member
Honny1
left a comment
There was a problem hiding this comment.
LGTM, once CI passes. (Hope we solve that fast.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
None
This PR addresses one part of #28367 by running
go fixon thepkg/machinedirectory from a Windows host.Changes include:
for range <int>(Go 1.22+).slices.Contains.I verified by building
podman-remoteon Windows using.\winmake.ps1 podman-remoteI got into errors when
.\winmake.ps1 validatepr. Details below,I also ran
.\winmake.ps1 localunitBEFORE and AFTER runninggo fix. There was 1 failure detected. Since it existed before I rango fixI am assuming it has nothing to do with the new changes. Details below,